-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Flex): flex 컴포넌트를 원하는 컴포넌트로 렌더할 수 있도록 수정 #139
Conversation
src/components/Flex/index.tsx
Outdated
ref: Ref<any> | ||
) => { | ||
const target = as ?? DEFAULT_ELEMENT; | ||
const Component = target; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
요거 target 말고 바로 Component 라는 상수명으로 할당해도 되지 않을까요 ?.?
따로 분리해주신 이유가 궁금합니당
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
이거 예전에 Text 만들 당시에 뭔가 타입 평가가 제대로 안 되서 이렇게 했던 것 같은데, 지금 해보니까 제대로 평가가 되네유....?
바로 없애버리겠읍니다
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
40a0842 에서 반영 완료!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
하는 김에 다른 애들도 같이 변경했슴다 cfdaa4e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
고생하셨습니다 -!
# [1.4.0](v1.3.0...v1.4.0) (2022-02-22) ### Features * **Flex:** flex 컴포넌트를 원하는 컴포넌트로 렌더할 수 있도록 수정 ([#139](#139)) ([a8d383c](a8d383c))
변경사항
Flex
컴포넌트가as
Props는 받고 있는데 쓰지를 않고 있었네요. 이 값을 이용하여Flex
를 사용할 때 원하는 컴포넌트로 렌더할 수 있게끔 변경합니다.집중적으로 리뷰 받고 싶은 부분이 있나요?
🙇